WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH]xl: Add missing start_time entry when create and

To: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: [Xen-devel] [PATCH]xl: Add missing start_time entry when create and restore VMs
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Fri, 14 May 2010 08:47:48 -0700 (PDT)
Cc:
Delivery-date: Fri, 14 May 2010 08:48:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BED3507.2010307@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BED3507.2010307@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> + vments[5] = libxl_sprintf(ctx, "%lu.%d", 
> start_time.tv_sec,(int)start_time.tv_usec/10000);
> + vments[i++] = libxl_sprintf(ctx, 
> "%lu.%d",start_time.tv_sec,(int)start_time.tv_usec/10000);

I don't think these work as intended.  For example, if
tv_usec is 10000, I think you want xxx.01 printed, not
xxx.1.  Maybe you want %lu.%02d?

And in any case, is there a reason to limit the precision
to two digits?  Why not %lu.%06d?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel