 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset}
| To: | Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset} |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 11 May 2010 13:04:47 +0100 |
| Cc: | Charles Arnold <CARNOLD@xxxxxxxxxx> |
| Delivery-date: | Tue, 11 May 2010 05:07:02 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C80EF281.13E9E%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acrw6REz0UxaAP7cTCqUiaoWrhsYvQADTL4VAAL4j2k= |
| Thread-topic: | [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset} |
| User-agent: | Microsoft-Entourage/12.24.0.100205 |
On 11/05/2010 11:39, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote: > Hm, well, I hate having to change this stuff as we always seem to end up > broken on some gcc or other. But otoh this will eliminate a bunch of code if > we do this unconditionally, and I'm particularly not keen on doing this only > for x86-32 and particular versions of gcc. I suggest the attached patch: it > should work fine so long as all our supported versions of gcc have > __builtin_memcpy and __builtin_memset. Given we nowadays only support GCC > 3.4+, I imagine we are okay in this regard. > > What do you think to this alternative patch? Jan, What about this alternative version which distinguishes between GCC 4.3+ (which should auto-inline quite sensibly) and earlier versions (which need help via macro mapping explicitly to __builtin_*)? -- Keir
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] page table pages with checkpoint functionality, 박은병 |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] mem_sharing: use paging_mode_hap, Christoph Egger |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset}, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset}, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
