Re: [Xen-devel] [PATCH] xen: implement vector callback for evtchn delivery

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 10.05.10 16:27 >>>
>--- a/xen/arch/x86/hvm/irq.c
>+++ b/xen/arch/x86/hvm/irq.c
>@@ -185,16 +185,16 @@
> 
> void hvm_assert_evtchn_irq(struct vcpu *v)
> {
>-    if ( v->vcpu_id != 0 )
>-        return;
>-

Shouldn't this conditional move ...

>     if ( unlikely(in_irq() || !local_irq_is_enabled()) )
>     {
>         tasklet_schedule(&v->arch.hvm_vcpu.assert_evtchn_irq_tasklet);
>         return;
>     }
> 
>-    hvm_set_callback_irq_level(v);
>+    if (is_hvm_pv_evtchn_vcpu(v))
>+        vcpu_kick(v);
>+    else

... here? I can't immediately see other changes in this patch
preventing the checked for condition from happening.

>+        hvm_set_callback_irq_level(v);
> }
> 
> void hvm_set_pci_link_route(struct domain *d, u8 link, u8 isa_irq)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel