 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH] xentrace: fix bug in t_info size
| To: | <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH] xentrace: fix bug in t_info size |
| From: | George Dunlap <george.dunlap@xxxxxxxxxxxxx> |
| Date: | Fri, 7 May 2010 19:25:47 -0500 |
| Cc: | george.dunlap@xxxxxxxxxxxxx |
| Delivery-date: | Fri, 07 May 2010 17:26:26 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
t_info size should be in bytes, not pages. This fixes a bug
that crashes the hypervisor if the total number of all pages
is more than 1024 but less than 2048.
Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
diff -r caea94988515 -r e633befe28ec xen/common/trace.c
--- a/xen/common/trace.c Fri May 07 11:45:18 2010 +0100
+++ b/xen/common/trace.c Fri May 07 19:20:52 2010 -0500
@@ -340,7 +340,7 @@
case XEN_SYSCTL_TBUFOP_get_info:
tbc->evt_mask = tb_event_mask;
tbc->buffer_mfn = t_info ? virt_to_mfn(t_info) : 0;
- tbc->size = T_INFO_PAGES;
+ tbc->size = T_INFO_PAGES * PAGE_SIZE;
break;
case XEN_SYSCTL_TBUFOP_set_cpu_mask:
xenctl_cpumap_to_cpumask(&tb_cpu_mask, &tbc->cpu_mask);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] pci passthrough error "unknown command"pci-ins", Weald Wind |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] xentrace: fix bug in t_info size, Jeremy Fitzhardinge |
| Previous by Thread: | [Xen-devel] pci passthrough error "unknown command"pci-ins", Weald Wind |
| Next by Thread: | Re: [Xen-devel] [PATCH] xentrace: fix bug in t_info size, Jeremy Fitzhardinge |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
