WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xenpm: remove wrong and pointless "current" indicato

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xenpm: remove wrong and pointless "current" indicator
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 07 May 2010 09:42:43 +0100
Delivery-date: Fri, 07 May 2010 01:42:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Using the CPU number to compare with an index into an array containing
only a seubset of CPUs isn't valid. And indicator isn't necessary here
at all since the CPU number being dealt with gets printed right before
this line.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2010-05-04.orig/tools/misc/xenpm.c  2010-05-06 14:52:45.000000000 +0200
+++ 2010-05-04/tools/misc/xenpm.c       2010-05-06 13:37:30.000000000 +0200
@@ -499,10 +499,7 @@ static void print_cpufreq_para(int cpuid
 
     printf("affected_cpus        :");
     for ( i = 0; i < p_cpufreq->cpu_num; i++ )
-        if ( i == cpuid )
-            printf(" *%d", p_cpufreq->affected_cpus[i]);
-        else
-            printf(" %d", p_cpufreq->affected_cpus[i]);
+        printf(" %d", p_cpufreq->affected_cpus[i]);
     printf("\n");
 
     printf("cpuinfo frequency    : max [%u] min [%u] cur [%u]\n",



Attachment: xenpm-strip-cpufreq-marker.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xenpm: remove wrong and pointless "current" indicator, Jan Beulich <=