RE: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into 'struct xen_netbk'.

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

I didn't add the --strict option. I will change it accordingly.

However for +typedef unsigned int pending_ring_idx_t;
this typedef is moved from netback.c, and not the type. 

Thanks,
Dongxiao

Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote:
>> Netback: Move global/static variables into struct xen_netbk.
> 
>  scripts/checkpatch.pl --strict
> ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch
> WARNING: do not add new typedefs
> #24: FILE: drivers/xen/netback/common.h:231:
> +typedef unsigned int pending_ring_idx_t;
> 
> CHECK: spinlock_t definition without comment
> #75: FILE: drivers/xen/netback/common.h:282:
> +       spinlock_t net_schedule_list_lock;
> 
> total: 0 errors, 1 warnings, 1 checks, 876 lines checked
> 
> /home/konrad/0001-Netback-Move-global-static-variables-into-struct-xe.patch
> has style problems, please review.  If any of these errors
> are false positives report them to
> 
>> 
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel