WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] mini-os: Fix xenbus initialisation

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] mini-os: Fix xenbus initialisation
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Thu, 29 Apr 2010 13:36:57 -0700
Cc: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 29 Apr 2010 13:37:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BBE5B27.6060305@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100405232748.GK23034@xxxxxxxxxxxxxxxxxxxxxxxxx> <4BBE2AE5.9050504@xxxxxxxx> <20100408212505.GG4705@xxxxxxxxxxxxxxxxxxxxxxxxx> <4BBE5B27.6060305@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 04/08/2010 03:39 PM, Jeremy Fitzhardinge wrote:
> On 04/08/2010 02:25 PM, Samuel Thibault wrote:
>   
>> Jeremy Fitzhardinge, le Thu 08 Apr 2010 12:13:41 -0700, a écrit :
>>   
>>     
>>> Reverting this change (b20f897d6010) makes hvm+stubdom work again.
>>>     
>>>       
>> Could you try to revert only parts of them?
>>   
>>     
> I narrowed it down to the first hunk of netfront part of the patch;
> applying everything but this works, adding it causes the failure.
>   

Ping?

Keir, can you revert this at least for now?

    J

>     J
>
> diff -r e98537246fe5 extras/mini-os/netfront.c
> --- a/extras/mini-os/netfront.c       Thu Apr 08 15:23:00 2010 -0700
> +++ b/extras/mini-os/netfront.c       Thu Apr 08 15:23:39 2010 -0700
> @@ -407,9 +407,9 @@
>      }
>  
>      snprintf(path, sizeof(path), "%s/state", nodename);
> -    err = xenbus_switch_state(xbt, path, XenbusStateConnected);
> +    err = xenbus_switch_state(xbt, path, XenbusStateInitialised);
>      if (err) {
> -        message = "switching state";
> +        printk("error writing net initialized: %s\n", err);
>          goto abort_transaction;
>      }
>  
>
>
>   


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>