Re: [Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

Jan Beulich wrote:
> Perhaps this should even be further generalized (e.g. to remove any
> "[!/]*:" pattern prefixes) to be more forward compatible?
>   

Right.  Need to handle the 'ioemu' subtype as well.  How about just
stripping of everything before the leading '/'?  E.g. like the attached
patch?

Regards,
Jim

diff -r c02cc832cb2d tools/hotplug/Linux/blktap
--- a/tools/hotplug/Linux/blktap        Tue Apr 13 18:19:33 2010 +0100
+++ b/tools/hotplug/Linux/blktap        Fri Apr 16 14:48:00 2010 -0600
@@ -59,10 +59,10 @@
 if [ -n "$t" ]
 then
     p=$(xenstore_read "$XENBUS_PATH/params")
-    # if we have a ':', chew from head including :
+    # if we have a ':', remove everything up to leading '/'
     if echo $p | grep -q \:
     then
-        p=${p#*:}
+        p="/${p#*/}"
     fi
 fi
 # some versions of readlink cannot be passed a regular file

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel