[Xen-devel] Re: [PATCH] make c/s 21089 work again with c/s 21092

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Bastian Blank <waldi@xxxxxxxxxx> 13.04.10 17:10 >>>
>On Tue, Apr 13, 2010 at 02:36:55PM +0100, Jan Beulich wrote:
>> Unfortunately the latter c/s' change to mpparse.c yielded the former
>> patch non-functional - Xen's serial port IRQ is not in IQR_DISABLED
>> state, yet must be allowed to get its trigger mode and polarity set
>> up in order for it to be usable.
>
>This looks not right. The original patch was designed to keep this
>function away from the irqs of the serial port. This patch adds another
>check for disallowing access but does not touch the IQR_DISABLED check.
>
>Please explain which machines have non-legacy configured interrupts for
>the first two serial ports.

I'm talking about PCI serial cards - in the one case I'm working with,
it sits on IRQ 17 (level, low) and hence Xen can't enable it until Dom0
retrieved sufficient information from ACPI. Since desc->status
doesn't have IRQ_DISABLED for such an interrupt anymore, your
patch basically made it impossible for the needed information to be
processed, and hence the IRQ could (again, i.e. as before my patch
was applied) not be enabled.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel