WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] p2m: merge ptp allocation

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] p2m: merge ptp allocation
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Tue, 13 Apr 2010 12:34:08 +0200
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 13 Apr 2010 03:34:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100413102221.GA4120@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201004131125.40545.Christoph.Egger@xxxxxxx> <20100413102221.GA4120@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Tuesday 13 April 2010 12:22:21 Tim Deegan wrote:
> Hi,
>
> At 10:25 +0100 on 13 Apr (1271154340), Christoph Egger wrote:
> > Attached patch merges ptp allocation in p2m.
> >
> > Signed-off-by: Christoph Egger <Christop.Egger@xxxxxxx>
> >
> > diff -r 105fdf064d27 xen/arch/x86/mm/hap/private.h
> > --- a/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:35:24 2010 +0200
> > +++ b/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:59:55 2010 +0200
> > @@ -30,5 +30,6 @@ unsigned long hap_gva_to_gfn_3_levels(st
> >  unsigned long hap_gva_to_gfn_4_levels(struct vcpu *v, unsigned long gva,
> >                                       uint32_t *pfec);
> >
> > +struct page_info *p2m_alloc_ptp(struct domain *d, unsigned long type);
>
> Why is this declared in hap/private.h when it's not a hap function?
> Maybe asm-x86/p2m.h would be a better place.

Ok, I'm fine with this change.
Keir: Do you want me to resend the diff or will you do that right before 
applying the patch?

>
> Otherwise, Ack.

Thanks.

> Tim.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>