WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Do not set execute permission on qemu-dm log fil

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Do not set execute permission on qemu-dm log file
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 6 Apr 2010 15:04:00 +0100
Delivery-date: Tue, 06 Apr 2010 07:05:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100326141437.GA16243@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20100326141437.GA16243@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Daniel Kiper writes ("[Xen-devel] [PATCH] Do not set execute permission on 
qemu-dm log file"):
> Patch for xen-3.4-testing/xen-unstable which do not
> allow to set execute permission on qemu-dm log file.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

You might want to grep the rest of the code for similar uses of
os.open.  The choice of 0777 as the default mode is ... surprising.

IMO this should be backported to 3.4 and to the 4.0 tree (but only
after the 4.0 release).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>