Re: [Xen-devel] [PATCH 05/11] libxl: Provide libxl_domain_rename

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 26 Mar 2010, Vincent Hanquez wrote:
> On 26/03/10 10:23, Ian Jackson wrote:
> > You are confused.  The purpose of this check is to check that the
> > existing name is as expected, not that the name is not unique
> > (although the lack of checking that the name is unique is also a bug).
> 
> I'm not confused, there's no need to check anything, libxl is here to 
> plumb whatever name the user of the library has chosen for its domain 
> into a xenstore entry: the name is opaque to libxl, and should remains 
> as such.
> 
> if you want some kind of migration lock, put in xl where you define the 
> policy.
> 


the domain name is not opaque to libxenlight:

- some public libxenlight structs contain the domain name;

- libxenlight writes the domain name to xenstore;

- libxenlight offers functions to convert domids into domain names and
vice versa;


all this before any of Ian's patches.

I think this proves that libxenlight takes care of domain names already
and this patch just adds another function to the library to complete its
functionalities, without breaking any unwritten rule.

But if you prefer we can move this function to libxl_utils.c.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel