WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH]x86: Remove redundant clear for cpu_online_map.

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH]x86: Remove redundant clear for cpu_online_map.
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Tue, 30 Mar 2010 13:41:23 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 29 Mar 2010 22:42:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrPy6GQmLLvZ5OZQz+le7hjxDrZ3Q==
Thread-topic: [PATCH]x86: Remove redundant clear for cpu_online_map.
As Yunhong indicated, the second clear for cpu_online_map should be redundant, 
remove it. 

x86: Remove redundant clear for cpu_online_map.

Remove it, maybe caused by accident diff operation. 

Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>

diff -r b60379dad533 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Fri Feb 05 13:57:20 2010 +0000
+++ b/xen/arch/x86/smpboot.c    Tue Mar 30 11:33:37 2010 +0800
@@ -1304,10 +1304,9 @@ int __cpu_disable(void)
 
        remove_siblinginfo(cpu);
 
+       /* It's now safe to remove this processor from the online map */
        cpu_clear(cpu, cpu_online_map);
        fixup_irqs();
-       /* It's now safe to remove this processor from the online map */
-       cpu_clear(cpu, cpu_online_map);
 
        cpu_disable_scheduler()

Xiantao

Attachment: remove-redundant-clear-cpu-online-map.patch
Description: remove-redundant-clear-cpu-online-map.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH]x86: Remove redundant clear for cpu_online_map., Zhang, Xiantao <=