WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86: s3: write_msi_msg: entry->msg should be in the

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: s3: write_msi_msg: entry->msg should be in the compatibility format
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Thu, 25 Mar 2010 17:02:00 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 25 Mar 2010 02:03:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrL+dSmFd6tXtoSToCjy6VPCxStYQ==
Thread-topic: [PATCH] x86: s3: write_msi_msg: entry->msg should be in the compatibility format
When Interrupt Remapping is used, after Dom0 S3, Dom0's filesystem might
become inaccessible as the SATA disk's MSI interrupt becomes buggy.
The cause is:
After set_msi_affinity() or setup_msi_irq() invokes write_msi_msg(),
entry->msg records the remappable format message; during S3 resume, Dom0
invokes the PHYSDEVOP_restore_msi hypercall to restore the MSI registers of
devices, and in pci_restore_msi_state() -> write_msi_msg(), the 'entry->msg'
of remappable format is passed, but in write_msi_msg() -> ... ->
msi_msg_to_remap_entry(), the 'msg' is assumed to be in compatibility format.
As a result, after s3, the IRTE is corrupted.

Actually the only users of 'entry->msg' are pci_restore_msi_state() and
dump_msi(). That's why we don't have issue except Dom0 S3.

Thanks,
-- Dexuan

Attachment: fix_s3_when_ir_and_msi_are_used.patch
Description: fix_s3_when_ir_and_msi_are_used.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86: s3: write_msi_msg: entry->msg should be in the compatibility format, Cui, Dexuan <=