 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 1/3] xen: Control-flow cleanup
| To: | Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 1/3] xen: Control-flow cleanup |
| From: | Bastian Blank <waldi@xxxxxxxxxx> |
| Date: | Wed, 24 Mar 2010 23:51:44 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 24 Mar 2010 15:52:51 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4BAA5189.8080503@xxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20100324115137.GA10770@xxxxxxxxxxxxxxxxxxxxxxx> <4BAA5189.8080503@xxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Mar 24, 2010 at 10:53:13AM -0700, Jeremy Fitzhardinge wrote:
> Thanks, I agree, but I tweaked it to use "goto out" to preserve the
> single return, and fixed some lines which can now be unwrapped with the
> shallower indent.
What is the reason for this single return except that it makes the code
less readable?
Bastian
--
Totally illogical, there was no chance.
-- Spock, "The Galileo Seven", stardate 2822.3
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] RE: Hey James, how to analyze this BSoD?, James Harper |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 3/3] xen: Don't register GSI in pre-setup, Bastian Blank |
| Previous by Thread: | Re: [Xen-devel] [PATCH 1/3] xen: Control-flow cleanup, Jeremy Fitzhardinge |
| Next by Thread: | [Xen-devel] [PATCH 2/3] xen: Map physical interrupt before setting up GSI, Bastian Blank |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
