This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] x86: fix improper return value from relinquish_m

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: fix improper return value from relinquish_memory()
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 24 Mar 2010 10:43:13 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 24 Mar 2010 07:44:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BAA04440200007800036BBB@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BAA00870200007800036B93@xxxxxxxxxxxxxxxxxx> <4BAA04440200007800036BBB@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Mar 24, 2010 at 11:23:32AM +0000, Jan Beulich wrote:
> >>> "Jan Beulich" <JBeulich@xxxxxxxxxx> 24.03.10 12:07 >>>
> >While apparently only a theoretical possibility (domain_kill() has a
> >BUG_ON() that wasn't reported to trigger so far), I still think it is
> >better to have the code cleaned up.
> Btw., the reason I was looking at that code was that we observe
> zombie domains - ones in DOMDYING_dead state, perhaps having
> almost none of their memory freed (shadowed guests appear to be
> particularly bad). In one of the reports, an interesting extra fact
> was that this happened only for the first 100 guests - any
> subsequent ones got destroyed properly (obviously to get there
> this requires quite a bit of memory in the host). Has anyone else
> observed this? Does this ring any bells?


B/c of the page count we had guests that would never have their mmap
count removed causing them to be zombie guests. Our fix, which wasn't
nice, was to have the guest domain id re-number and shove it and its
remaining page ownership (at that point it only has some pages in Dom0
and DomU) in a corner. 

Xen-devel mailing list