This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0 of 5] PV on HVM Xen

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 5] PV on HVM Xen
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 12 Mar 2010 13:53:18 -0800
Cc: Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Fraser <Keir.Fraser@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Delivery-date: Fri, 12 Mar 2010 13:55:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1003121024590.27222@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1003101457100.28412@kaball-desktop> <201003121123.33935.sheng@xxxxxxxxxxxxxxx> <alpine.DEB.2.00.1003121024590.27222@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3
On 03/12/2010 02:42 AM, Stefano Stabellini wrote:
On Fri, 12 Mar 2010, Sheng Yang wrote:
On Wednesday 10 March 2010 23:46:54 Stefano Stabellini wrote:
Hi all,

And next time when you send out the patch, please be more respect to my work.

You dropped all the original author(me) of patchset, and only add a sign-off
for me. If you don't aware the difference, here is a snippet of

I am truly sorry and apologise for it, I would never want to give you
the impression of being disrespectful of you and your work.
If you pay attention I manually wrote in the comments of all the past
versions of the patches that you were the original author, this time I
just forgot.
I guess it is really the time I start using git-send-email :)

Your work has been really important for my series and you deserve the
credit for it independently from which patch series gets applied.

Best practise for this kind of thing is to use Sheng's patch verbatim, then apply a separate delta on top to make the changes you want. That way:

   * credit can be property attributed
   * it helps with maintaining two parallel-but-converging git
     branches, because all the common stuff is genuinely common, and
     the variations can work from there, and
   * if Sheng updates his patches (review, bugfix, etc), then we can
     easily see how those changes affect your changes.

For example, I just rebased your previous patch posting so that it is rooted on Sheng's two base patches, as they're completely common.

The latest of both patches is in xen/pvhvm-sheng and -stefano.


Xen-devel mailing list