This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 5 of 5] xen pci platform device driver

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 5 of 5] xen pci platform device driver
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 12 Mar 2010 18:11:40 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 12 Mar 2010 10:08:07 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B996130.3030709@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1003101504480.28412@kaball-desktop> <4B996130.3030709@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 11 Mar 2010, Jeremy Fitzhardinge wrote:
> On 03/10/2010 07:47 AM, Stefano Stabellini wrote:
> > Hi all,
> > this patch adds the xen pci platform device driver that is responsible
> > for initializing the grant table and xenbus in PV on HVM mode.
> > Few changes to xenbus and grant table are necessary to allow the delayed
> > initialization in HVM mode.
> > Finally grant table needs few additional modifications to work in HVM
> > mode.
> >
> Will you add the ability to event channels via this device's interrupt
> for back-compat?

I just made it work, but I am not sending another version of my patch
series with the backward compatibile callback mechanism to the list
right now because I would like to solve the issue with Sheng first: I
hope my next series is going to be based on top of his.

> > +
> > +#define XEN_IOPORT_MAGIC_VAL 0x49d2
> > +#define XEN_IOPORT_LINUX_PRODNUM 0xffff
> >
> Surely there's a better header to put this stuff?

I'll move them to include/xen/platform_pci.h

> Is there any way of getting these devices back?


> How does the unplug appear to the kernel?  Does it depend on this
> happening before the normal disk/net/etc drivers come up?

basically the devices suddenly disapper for the pci bus, so it would be
better if it happens before the disk and net drivers come up.

> Shouldn't the unplug happen as each PV device comes up, rather than
> having to pre-specify it here?

this is not how current Windows PV drivers work AFAIK, but it is a good
idea. I'll try to do this in the next version.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>