This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] first attempt of pvscai backend driver port to pvops

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
Subject: RE: [Xen-devel] first attempt of pvscai backend driver port to pvops
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Fri, 12 Mar 2010 11:37:05 +1100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 11 Mar 2010 16:37:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B99864E.3080907@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AEC6C66638C05B468B556EA548C1A77D01918D84@trantor> <4B99864E.3080907@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrBeF3UHE5o5nqXTOWG/ReN8uwMEQAAuIOA
Thread-topic: [Xen-devel] first attempt of pvscai backend driver port to pvops
> It does need some cleaning up.  Run it through
> linux/scripts/checkpatch.pl and iterate until its fairly clean (as
> as possible without making it barbarous).  Most obvious is that kernel
> code uses 8-width hard tabs.
> The patch also seems to contain usbback.  Did you mean to include it?

I sure didn't. Not sure how that got there...
> If possible and sensible, split the patch into logically separate
> (like introduce infrastructure, use infrastructure for a, for b, for
> c).  However for these kinds of "new subsystem" patches, it often
> most sense to just have one large patch adding the new code.
> Please base the patches on (ideally) 2.6.31 or .32.  If you need some
> Xen infrastructure (which is likely), then base the patch on the
> xen/dom0/backend/common branch.

They are based on xen/master at the moment.

> Mail your patches to the list for review (but, please, inlined plain
> text).  But the easiest way for me to include the patches is if I can
> pull them from your git server.  If you can't make your own machine
> accessible, you can set up an account on github.com, or ask for an
> account on kernel.org.

I'll look at doing that.

> I haven't actually looked at the substance of the patch yet.

Probably best not to bother until I've cleaned up some of the above.



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>