This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][v7] PV extension of HVM(hybrid) support in Xen

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][v7] PV extension of HVM(hybrid) support in Xen
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 11 Mar 2010 12:02:09 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Ian, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 11 Mar 2010 04:03:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201003111011.46605.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201003081521.39829.sheng@xxxxxxxxxxxxxxx> <20100310144446.GA4334@xxxxxxxxxxxxxxxxxxxxxxx> <201003111011.46605.sheng@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 02:11 +0000 on 11 Mar (1268273506), Sheng Yang wrote:
> > Shouldn't this be gated on (d->hvm_pv_enabled & XEN_HVM_PV_CLOCK_ENABLED)
> > rather than (eip != 0)?
> Um... I think no other HVM should call this, and evtchn shouldn't work
> without PV clocksource... And it have two meaning here: one is setting
> up the start up IP for AP, another is initial PV clock.  I would
> update this to get it more clear.

Yes, I was just talking about the last line, where you set the offset to
zero.  Since you have introduced a flag that says whether the
clocksource is enabled, you should use it. 
> > Maybe use cpuid_edx() here?
> Um? It's not native cpuid, but the one configuration file specific.

Yes, you're quite right.  I misread the code. 



Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>