[Xen-devel] Re: [PATCH][v7] PV extension of HVM(hybrid) support

At 02:11 +0000 on 11 Mar (1268273506), Sheng Yang wrote:
> > Shouldn't this be gated on (d->hvm_pv_enabled & XEN_HVM_PV_CLOCK_ENABLED)
> > rather than (eip != 0)?
> 
> Um... I think no other HVM should call this, and evtchn shouldn't work
> without PV clocksource... And it have two meaning here: one is setting
> up the start up IP for AP, another is initial PV clock.  I would
> update this to get it more clear.

Yes, I was just talking about the last line, where you set the offset to
zero.  Since you have introduced a flag that says whether the
clocksource is enabled, you should use it. 
 
> > Maybe use cpuid_edx() here?
> 
> Um? It's not native cpuid, but the one configuration file specific.

Yes, you're quite right.  I misread the code. 

Thanks, 

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH 7/7] xen: Enable event channel of PV extension of HVM, Stefano Stabellini

Next by Date:

Re: [Xen-devel] Xen 3.4 & tg3 gigabit ethernet stalls, Teck Choon Giam

Previous by Thread:

[Xen-devel] Re: [PATCH][v7] PV extension of HVM(hybrid) support in Xen, Sheng Yang

Next by Thread:

[Xen-devel] Xen-4.0.0 RC5 Test Report. Xen: #20990 & Dom0: #0a6130..., Xu, Jiajun

Indexes:

[Date] [Thread] [Top] [All Lists]