This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 6/7] xen: Enable PV clocksource for HVM

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 6/7] xen: Enable PV clocksource for HVM
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 4 Mar 2010 20:25:03 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Delivery-date: Thu, 04 Mar 2010 12:25:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B8FF0A3.9060305@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1267695416-14988-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1267695416-14988-7-git-send-email-sheng@xxxxxxxxxxxxxxx> <4B8FF0A3.9060305@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010-03-04 at 09:40 -0800, Jeremy Fitzhardinge wrote:
> > +
> > +static void __init init_pv_clocksource(void)
> > +{
> > +     if (enable_hvm_pv(HVM_PV_CLOCK))
> > +             BUG();
> >    
> BUG is a bit severe.  Will it really never, ever fail?  

When running on a hypervisor without these extension, for example.

Ian Campbell

My polyvinyl cowboy wallet was made in Hong Kong by Montgomery Clift!

Xen-devel mailing list