This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][v5] PV extension of HVM(hybrid) in support in Xe

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][v5] PV extension of HVM(hybrid) in support in Xen
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 4 Mar 2010 15:04:31 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 04 Mar 2010 07:06:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201003041737.14555.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201003041737.14555.sheng@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)

Given that we now have a similar feature from Stefano I'd like to see
them resolved into a single patchset. 

At 09:37 +0000 on 04 Mar (1267695434), Sheng Yang wrote:
> +     if (a.flags & HVM_PV_CLOCK) {
> +             d->hvm_pv_enabled |= XEN_HVM_PV_CLOCK_ENABLED;
> +             update_domain_wallclock_time(d);
> +             /* Other vcpus are adjusted during the start-up */
> +             hvm_funcs.set_tsc_offset(d->vcpu[0], 0);
> +     }

This still makes no sense to me.  Either it should affect the calling
vcpu (i.e., current) or it should affect all online vcpus.

Also, whatever the semantics, they should be documented in comments in
the header file.


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list