This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] x2apic mode vs. interrupt remapping

To: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] x2apic mode vs. interrupt remapping
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Thu, 4 Mar 2010 12:15:50 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 03 Mar 2010 20:16:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EB8593BCECAB3D40A8248BE0B6400A384625650E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B8E6E3802000078000326ED@xxxxxxxxxxxxxxxxxx> <EB8593BCECAB3D40A8248BE0B6400A38462564F7@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B8E775E0200007800032723@xxxxxxxxxxxxxxxxxx> <EB8593BCECAB3D40A8248BE0B6400A3846256505@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B8E7CBC020000780003276E@xxxxxxxxxxxxxxxxxx> <EB8593BCECAB3D40A8248BE0B6400A384625650E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acq6287q2WZGf8r9QE+XOBqeaLM6LAAARFyAAByte6A=
Thread-topic: [Xen-devel] x2apic mode vs. interrupt remapping
Zhang, Xiantao wrote:
> Jan Beulich wrote:
>>>>> "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> 03.03.10 15:09 >>>
>>> When iommu_supports_eim is called in enable_x2apic, drhd is already
>>> parsed in acpi_boot_init,
>> Provided there is any - in the given case there is none. Perhaps the
>> function should also return 0 if the list of drhd-s is empty?
> Yeah, if the drhd list is empty, it should return 0 instead of the
> default 1.  The condition check maybe need enhancement. Xiantao

Oh, yes, I missed that!
Thank you for pointing this out. 

I'll make a patch for this soon.

-- Dexuan

>>> so iommu_supports_eim should return hardware's real capability. That
>>> is to say, if eim is no supported on platform, x2apic shouldn't be
>>> enabled at all.
>> Jan
Xen-devel mailing list