This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/7] xen/hvm: Xen PV extension of HVM initializat

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/7] xen/hvm: Xen PV extension of HVM initialization
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 01 Mar 2010 17:43:37 -0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, "Yaozu \(Eddie\) Dong" <eddie.dong@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 01 Mar 2010 17:43:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201003020938.53630.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1267436315-24486-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1267436315-24486-4-git-send-email-sheng@xxxxxxxxxxxxxxx> <4B8C63B0.2090507@xxxxxxxx> <201003020938.53630.sheng@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1
On 03/01/2010 05:38 PM, Sheng Yang wrote:
Why use this?  Why not just set the domain type to HVM, and leave the
"status" field as a bitset of available paravirtualizations?
A annoy thing in pv drivers is that it would test if the domain type is _NOT_
XEN_NATIVE. So set the domain to XEN_HVM_DOMAIN would result in PV driver
initialization then probably panic. Maybe we can do something to PV drivers,
as patch 6 and a part of patch 7.

In that case, change them to specifically test for PV until they're ready to deal with an HVM environment.

Part of pv_ops are overlapped. I would try if a new file would bring much

It shouldn't do; un-static things if necessary.

+       .align PAGE_SIZE_asm
+       .skip PAGE_SIZE_asm
Why does this need to be defined in asm?  Can't it be either allocated
or defined in C?
I think we need a aligned page, as hypercall page.

That can be declared in C with the __page_aligned_bss annotation. And couldn't you dynamically allocate it with the bootmem allocator?

I think "status" is a misnomer here.  Isn't it specifically a set of PV
features which are active?
Could you give a suggestion of the name? I am not a native English speaker...



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>