This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] linux/blkfront: fixes for 'xm block-detach ... -

To: "Daniel Stodden" <daniel.stodden@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/blkfront: fixes for 'xm block-detach ... --force'
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 01 Mar 2010 10:07:05 +0000
Cc: JeremyFitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 01 Mar 2010 02:07:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1267221034.30168.71.camel@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B5443BC020000780002A81E@xxxxxxxxxxxxxxxxxx> <1267221034.30168.71.camel@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Daniel Stodden <daniel.stodden@xxxxxxxxxx> 26.02.10 22:50 >>>
>I think this one resulted in blkfront_remove (from xenbus) racing
>against blkif_release (run from close(bdev)). 
>Both running for their respective kfree(info) vs. subsequent
>dereferences. Or just to leak info entirely.
>We only had blkfront_closing() on either thread before, which serializes
>around the bd_mutex.
>I'm currently thinking that info now rather wants a refcount of its own.
>Ideally replacing is_ready entirely, maybe.
>Any thoughts?

Could you check the fixup patch I sent just a couple of minutes
ago (paralleling c/s 993 on the 2.6.18 tree)?

Thanks, Jan

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH] linux/blkfront: fixes for 'xm block-detach ... --force', Jan Beulich <=