Re: [Xen-devel] [PATCH 2/5] [POST-4.0]: HVM NUMA guest: pass NUMA information to libxc

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 22/02/2010 11:06, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

>> I don't know the coding style, but you seem to have two different
>> version of it. Here you do the 'for (i= ..')
> It seems that Xen does not have a consistent coding style in this
> respect, I have seen both versions in Xen already. I usually do
> coding-style-by-copying, looking at similar nearby statements and
> applying the style to the new one (useful if you do code changes in Xen
> HV, tools, ioemu, etc.). That seemed to fail here.
> 
> Keir, is there a definite rule for the "space after brace" issue?

Follow the style of the file or module you edit. The style I prefer is
followed in most 'new' (as opposed to from-Linux) files in the hypervisor
itself, like xmalloc.c, page_alloc.c, x86_emulate.c, and loads of others.
Outside the hypervisor itself, I can't be bothered to police it and some
others seem to have intransigent opinions on the right-way-to-write-code. As
long as there is consistency at least on a per-file basis, personally I can
live with whatever.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel