WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PCI passthrough w/ shared IRQ in xen/master

To: Michael D Labriola <mlabriol@xxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] PCI passthrough w/ shared IRQ in xen/master
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Fri, 19 Feb 2010 16:45:08 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 19 Feb 2010 14:07:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <OF050DF4D7.ECD5A23E-ON852576CF.0069869D-852576CF.0069B54B@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF6465D584.AC588822-ON852576CF.0061C569-852576CF.0061EE7D@xxxxxxxx> <OF050DF4D7.ECD5A23E-ON852576CF.0069869D-852576CF.0069B54B@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
> > > There is a missing patch that I haven't pushed in the pcifront branch:
> > > 
> > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> > > index e138053..923de2e 100644
> > > --- a/arch/x86/pci/xen.c
> > > +++ b/arch/x86/pci/xen.c
> > > @@ -25,7 +25,7 @@ static int xen_pcifront_enable_irq(struct pci_dev 
> > *dev)
> > >     if (dev->irq < 0)
> > >        return -EINVAL;
> > > 
> > > -   rc = xen_allocate_pirq(dev->irq, 0, "pcifront");
> > > +   rc = xen_allocate_pirq(dev->irq, 1 /* share */, "pcifront");
> > >     if (rc < 0) {
> > >        dev_warn(&dev->dev, "Xen PCI IRQ: %d, failed to register:%d\n",
> > >            dev->irq, rc);
> > > 
> > > 
> > 
> > 
> > HA!  That's an important one-line diff!  Now my ATM card works w/ shared 
> 
> > IRQ on domU.  :-)
> > 
> > Now we just have to get a better fix for dom0 than commenting out the 
> > entire note_interrupt() function...
> 
> Actually, I just verified that that patch makes the note_interrupt() 
> gutting unnecessary.  With just that one line changed, I'm up and running 
> perfectly.

Excellent.

Jeremy, could you pull
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git pcifront-2.6.31.6 

in your xen/pcifront and merge it to xen/master, please?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel