WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: TIME_SLOP vs. timer_slop

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: TIME_SLOP vs. timer_slop
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 10 Feb 2010 13:28:37 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 Feb 2010 05:28:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B72A96C020000780002EB6B@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqqRfa9kX9byfTJQcGZ6FWTIQTNfwADvyb4
Thread-topic: TIME_SLOP vs. timer_slop
User-agent: Microsoft-Entourage/12.23.0.091001
On 10/02/2010 11:41, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:


> is there a reason why schedule.c and timer.c don't both use the latter,
> command line controllable value?
> 
> Also, aren't the comment and code in vcpu_periodic_timer_work() out
> of sync with the actual implementation in timer.c in that a timer will
> never expire early (with timer_slop only being used to set an upper
> bound on the expiry range)?

Yes, true. Thanks for that; it's now fixed as c/s 20921.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>