[Xen-devel] [PATCH] tools/xenconsole: fix Segmentation fault

[Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>]

Segmentation fault occurs if DOMID isn't specified.
Some check be added to output error message in this situation.

Signed-off-by: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>

diff -r 7b751b0e6f1b -r 22dfbd21b44e tools/console/client/main.c
--- a/tools/console/client/main.c       Thu Feb 04 19:40:19 2010 +0000
+++ b/tools/console/client/main.c       Mon Feb 08 11:31:06 2010 +0800
@@ -287,7 +287,13 @@
                        exit(EINVAL);
                }
        }
-       
+
+       if (optind >= argc) {
+               fprintf(stderr, "DOMID should be specified\n");
+               fprintf(stderr, "Try `%s --help' for more information.\n",
+                       argv[0]);
+               exit(EINVAL);
+       }
        domid = strtol(argv[optind], &end, 10);
        if (end && *end) {
                fprintf(stderr, "Invalid DOMID `%s'\n", argv[optind]);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel