WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedby swiot

To: Ronny.Hegewald@xxxxxxxxx
Subject: Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedby swiotlb
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Fri, 5 Feb 2010 11:24:29 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 05 Feb 2010 09:04:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <17472149.3960821265244940127.JavaMail.servlet@kundenserver>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <17472149.3960821265244940127.JavaMail.servlet@kundenserver>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
> No, your first statement was correct. It would always return the same mask 
> for 32-bit and 64-bit, because of the 32-bitness of the return-variable 
> 'dma_mask'.
> 
> So the following patch maybe would be more appropriate?

I think it isn't neccessary. The 'dmal_alloc_coherent_mask' returns an
unsigned long. On 32-bit 'unsigned long' is a 4-byte value, and
on 64-bit that is 8-byte value. So I think your previous patch:
http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00038.html
is correct as when it is compiled under 64-bit it would return a 64-bit
value and when compiled under 32-bit, it would return a 32-bit value.
This would mimick the behavior of upstream logic.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>