WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Tue, 2 Feb 2010 13:47:39 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>
Delivery-date: Mon, 01 Feb 2010 21:48:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C78C7C2B.8681%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EB8593BCECAB3D40A8248BE0B6400A3835ACB174@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C78C7C2B.8681%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqfEjBdAvKTlDZES9GP92/daWtXOgBn3NcBAABXF2AAAn8xkQBvuV2QAAb4ydAAFXdH4AAK5Ei0AAUXLYAAA4f8eAAjs2iQ
Thread-topic: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
Keir Fraser wrote:
> On 01/02/2010 11:21, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> 
>> 5. a simple way to solve the issue is, to make sure scan loop of
>> NTFY = scan loop of PRSC, and to make sure NTFY always scan 2^n
>>     vcpus. However, NTFY scan loop may change in the future, not
>> necessary equal to 2^n, and not necessary equal to scan loop of
>> PRSC. That's the reason why I use for() loop inside of
>> decision_tree() in method NTFY at the patch I send Jan 
>> 27. It will work correctly under whatever conditions, and keep
>> mk_dsdt.c easier to understand. Decision_tree indeed reduce scan
>> greatly, but it's not in key path.
> 
> Ah, now I understand!
> 
> Okay, how about the attached patch? This fixes the bug by inlining
> NTFY into PRSC, and also uses HVM_MAX_VCPUS as appropriate.
> 
> Please take a look and also test it. I'll apply it if/when you Ack it.
> 
>  -- Keir

Keir,

It's really good to merge NTFY with PRSC, it's easy to understand and effective!
I just change a little, as attached 01-dsdt.
I test these 2 patches, it's OK.

Thanks,
Jinsong

Attachment: 00-dsdt
Description: 00-dsdt

Attachment: 01-dsdt
Description: 01-dsdt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel