WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Mon, 1 Feb 2010 11:31:06 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>
Delivery-date: Sun, 31 Jan 2010 19:31:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C78B6927.851B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EB8593BCECAB3D40A8248BE0B6400A3835ACAB98@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C78B6927.851B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqfEjBdAvKTlDZES9GP92/daWtXOgBn3NcBAABXF2AAAn8xkQBvuV2QAAb4ydAAFXdH4A==
Thread-topic: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
Keir Fraser wrote:
> On 31/01/2010 14:04, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> 
>> According to your suggestion, I plan to modify the patch as:
>> 1. cancel method NTFY, merge it into method PRSC;
>> 2. at method PRSC, only scan 'maxvcpus' times. we can transfer
>> 'maxvcpus' (which comes from cmdline) from qemu to dsdt side through
>> bios_info; 
>> 3. at mk_dsdt.c, add some comments to make it clear;
>> Do you think it OK?
> 
> I don't even mind if you don't do #2. That's up to you. Bear in mind
> that to be able to merge NTFY into PRSC, you will have to completely
> unroll PRSC (one way to view it is moving the loops out of the DSDT
> and into mk_dsdt.c, to be executed at build time and produce
> straight-line code). That would mean you emit the code to check
> against max_vcpus 128 times. Is it worth it? I don't know.

Keir,

How about the followed update:
1. keep original method NTFY, keep decision_tree to reduce scan loop;
2. update method PRSC
    1). transfer para 'maxvcpus' (comes from config file) from qemu to 
mk_dsdt.c through bios_info;
    2). at PRSC, only scan 'maxvcpus' vcpus;
because maxvcpus< 128, no risk for NTFY then.

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel