WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xend: Fix non-contiguous NUMA node assignment

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: Fix non-contiguous NUMA node assignment
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 18 Jan 2010 09:19:44 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "yunhong.jiang@xxxxxxxxx" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Mon, 18 Jan 2010 01:20:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B542170.6000202@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqYG3f+t9w3A5CcSeGIElGD5GArGAAA+cVn
Thread-topic: [Xen-devel] [PATCH] xend: Fix non-contiguous NUMA node assignment
User-agent: Microsoft-Entourage/12.23.0.091001
On 18/01/2010 08:53, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> Keir Fraser wrote:
>> I had a go myself: see c/s 20817. This keeps nr_nodes as well as
>> max_node_id, and continues to use it where it seemed to make sense to do so.
> 
> c/s 20817 seems OK to me. Actually that was how I started, but then
> decided to drop max_node_id because I didn't see the sense in keeping
> two variables which actually differ just by 1.

They don't merely differ by one if there are holes in the node-id namespace.
Can that happen in practice? I'm not sure; but it's easy enough for the
tools to handle that case, so they might as well.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel