[Xen-devel] Re: [PATCH] numa: fix problems with memory-less nodes

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2010 16:30, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> If we decided to not report memory-less nodes in physinfo we should also
> skip them in the node_to_{cpu,memory,dma32_mem} Python lists. Currently
> Xen will not start guests on machines with memory-less nodes which are
> not the last ones. On an 8-node machine with empty nodes 4 and 5 "xm
> info" was reporting wrongly, also the node assignment algorithm crashed
> with a division by zero error.
> The attached patch fixes this by skipping empty nodes in the enumeration
> of resources.

Where to begin? Firstly, I thought that the ordering of nodes in the
node_to_* lists actually mattered -- the lists are indexed by nodeid (a
handle which can be passed to other Xen interfaces) are they not? If you
don't include empty entries, then the index position of entries is no longer
meaningful.

Secondly, you avoid appending to the node_to_cpu list if the node is
cpu-less. But you avoid appending to the node_to_{memory,dma32} lists only
if the node is *both* cpu-less and memory-less. That's not even consistent.

Please just fix the crap Python code.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel