WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] build fixes

Christoph Egger writes ("[Xen-devel] build fixes"):
> Attached patch fixes Xen build on NetBSD.

Nack.

> +#include <sys/wait.h> /* for pid_t */

This is fine but should read:
   #include <sys/wait.h>
as there is no point putting
   /* for somethingorother */
after every #include.

> -        if (!isdigit(p[i])) {
> +        if (!isdigit((uint8_t)p[i])) {

This is correct on all platforms.  But it should be fixed by some more
general approach, as it's needed for almost every call to a ctype
macro.

> -    seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
> +    seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);

This is just wrong.  It will break on >2G files.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>