WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86: minor cleanup to arch_memory_op()

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: minor cleanup to arch_memory_op()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 12 Jan 2010 11:09:27 +0000
Delivery-date: Tue, 12 Jan 2010 03:09:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
There's a function-wide variable rc, so no need to re-declare it in
individual case handling blocks.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2010-01-06.orig/xen/arch/x86/mm.c   2010-01-06 11:23:46.000000000 +0100
+++ 2010-01-06/xen/arch/x86/mm.c        2010-01-12 12:03:44.000000000 +0100
@@ -4237,7 +4237,6 @@ long arch_memory_op(int op, XEN_GUEST_HA
         struct xen_add_to_physmap xatp;
         unsigned long prev_mfn, mfn = 0, gpfn;
         struct domain *d;
-        int rc;
 
         if ( copy_from_guest(&xatp, arg, 1) )
             return -EFAULT;
@@ -4349,7 +4348,6 @@ long arch_memory_op(int op, XEN_GUEST_HA
     {
         struct xen_foreign_memory_map fmap;
         struct domain *d;
-        int rc;
 
         if ( copy_from_guest(&fmap, arg, 1) )
             return -EFAULT;
@@ -4401,7 +4399,6 @@ long arch_memory_op(int op, XEN_GUEST_HA
         struct memory_map_context ctxt;
         XEN_GUEST_HANDLE(e820entry_t) buffer;
         unsigned int i;
-        int rc;
 
         if ( !IS_PRIV(current->domain) )
             return -EINVAL;



Attachment: xen-x86-memory-op-cleanup.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86: minor cleanup to arch_memory_op(), Jan Beulich <=