Re: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch ioctl

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 11/01/2010 15:42, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>  #define IOCTL_PRIVCMD_MMAPBATCH                                        \
>>>         _IOC(_IOC_NONE, 'P', 3, sizeof(privcmd_mmapbatch_t))
>>> +#define IOCTL_PRIVCMD_MMAP_BATCH                               \
>>> +       _IOC(_IOC_NONE, 'P', 4, sizeof(privcmd_mmap_batch_t))
>> 
>> Distinguishing the old vs new ioctl by only a _ in the middle seems a
>> bit horrid. MMAPBATCH2 would at least be less prone to confusion...
> 
> Otoh it clearly tells that the two are very similar...

As does MMAPBATCH2. I actually strongly suggest IOCTL_PRIVCMD_MMAPBATCH_V2,
which makes the situation even more crystal clear. Distinguishing based on a
single underscore, to make the new name 'nice', is misplaced aestheticism.
In particular, the tools end up referencing both names (for compatibility)
and a clearer name makes the code more intelligible.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel