Ok, I will take that.
--jyh
>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Saturday, December 26, 2009 3:57 PM
>To: Jiang, Yunhong
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [PATCH] Correct handling node with CPU populated but no memory
>populated
>
>On 25/12/2009 10:42, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>
>> BTW, when I was working on the patch, I'm really confused by
>> srat_detect_node() and init_cpu_to_node().
>>
>> Firstly, Per my understanding to the code itself, these two functions
>> achieve
>> the same purpose, but I can't understanding why srat_detect_node need be
>> called after the CPU is up. As this is backported from kernel, so I checked
>> linux kernel. In linux kernel, the srat_detect_node is mainly for one quirk
>> for AMD platform, but that quirk is not implemented in Xen side. So is the
>> quirk is really needed?
>>
>> Also, are there any special reason that init_cpu_to_node() can't be called
>> right after numa_initmem_init()? I think it will be cleaner if we setup the
>> whole numa information in one place. Originally I suspect it is related to
>> generic_apic_probe(), but after checking the code, I didn't find anything
>> related. Did I miss anything?
>
>I have no direct involvement in the NUMA code that got ported, and I think
>the guy that originally did the port has moved on. If you think it can be
>cleaned up and improved, please go ahead.
>
> -- Keir
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home