WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Xen crash in poll_timer_fn

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: Xen crash in poll_timer_fn
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 24 Dec 2009 12:16:49 +0000
Cc:
Delivery-date: Thu, 24 Dec 2009 04:17:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ED3036A092A28F4C91B0B4360DD128EA304F0D0B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqEjKX7ee8AgX/CQtCYlUm06UHZ3gABlHAX
Thread-topic: Xen crash in poll_timer_fn
User-agent: Microsoft-Entourage/12.23.0.091001
On 24/12/2009 11:31, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> Hi, I occasionally meet with xen crash when the PV guest shuts down.
> BTW, I'm using xen c/s 20702.
> Per the log, the reason is: v->domain->poll_mask is NULL in poll_timer_fn().
> 
> The poll_mask is freed and set to NULL in domain_kill() -> evtchn_destroy(),
> but the poll_timer may keep active until complete_domain_destroy() ->
> sched_destroy_vcpu() -> kill_timer(). Between them, the timer may be fired and
> poll_timer_fn() would access the NULL pointer and cause the crash.
> 
> Maybe here we should move kill_timer() a little earlier, or free the poll_mask
> a little later?

Easiest just to free the mask later. Should be fixed by c/s 20722.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>