[Xen-devel] Re: [PATCH] linux/balloon: Fix hugepage-related bugs

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>

>>> Dave McCracken <dcm@xxxxxxxx> 21.12.09 20:50 >>>
>@@ -595,7 +600,7 @@ void free_empty_pages_and_pagevec(struct
>       npages = (nr_pages + (balloon_npages-1)) >> balloon_order;
> 
>       mutex_lock(&balloon_mutex);
>-      for (i = 0; i < nr_pages; i++) {
>+      for (i = 0; i < npages; i++) {
>               page = pagevec[i << balloon_order];
>               BUG_ON(page_count(page) != 1);

Wouldn't it be reasonable to also extend this check to all constituent
pages?

>               balloon_append(page);

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel