WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon i

To: "Dave McCracken" <dcm@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 18 Dec 2009 07:52:45 +0000
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 17 Dec 2009 23:52:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200912171433.04459.dcm@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B2907320200007800026472@xxxxxxxxxxxxxxxxxx> <4B290BA3020000780002648D@xxxxxxxxxxxxxxxxxx> <200912171433.04459.dcm@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Dave McCracken <dcm@xxxxxxxx> 17.12.09 21:33 >>>
>I don't see anything wrong with the error path.  It correctly walks back down 
>the pagevec and frees all the pages it's allocated so far.

Oh, you're probably looking at the code past the err: label, but I was
referring to the handling of a failed apply_to_page_range().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel