WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-devel

[Top] [All Lists]

RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support

from [Jan Beulich]

[Permanent Link][Original]

To:	"Dongxiao Xu" <dongxiao.xu@xxxxxxxxx>
Subject:	RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Fri, 11 Dec 2009 17:01:18 +0000
Cc:	Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date:	Fri, 11 Dec 2009 09:01:39 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<EADF0A36011179459010BDF5142A457501D13FE822@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<EADF0A36011179459010BDF5142A457501D13FE7E9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B224B6402000078000253AC@xxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501D13FE7FC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B22591302000078000253E8@xxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501D13FE822@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>> "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> 11.12.09 17:22 >>>
>       Here is the updated one, I add the BUILD_BUG_ON() and some comments. 

I still don't think that's what we want: It's not a bug if MSR_INDEX_SIZE
is not 3. A BUILD_BUG_ON() should check things that ought to be
guaranteed, but shouldn't require adjustment each time some table
gets expanded/shrunk. What you want to minimally check is
ARRAY_SIZE(msr_index) == VMX_INDEX_MSR_TSC_AUX &&
VMX_INDEX_MSR_TSC_AUX == VMX_MSR_COUNT - 1.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao Re: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Jan Beulich RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Jan Beulich RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Jan Beulich <= RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Dan Magenheimer RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Jan Beulich

Previous by Date:	RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao
Next by Date:	[Xen-devel] vncunused=0 option prevent additional hvm hosts to run, Guillaume Rousse
Previous by Thread:	RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao
Next by Thread:	RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support, Xu, Dongxiao
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix