WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] libxenlight: implement libxl_set_memory_target

To: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] libxenlight: implement libxl_set_memory_target
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 10 Dec 2009 13:37:31 +0000
Cc: Vincent, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 10 Dec 2009 05:40:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B200CD5.30807@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20091208200031.4903B5980EB@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B1EB743.3090102@xxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0912091249190.9654@kaball-desktop> <4B200CD5.30807@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 9 Dec 2009, Andres Lagar-Cavilla wrote:
> Stefano Stabellini wrote:
> > On Tue, 8 Dec 2009, Andres Lagar-Cavilla wrote:
> >   
> >> Hi,
> >> couple of comments:
> >> - PV domains without videoram won't be able to use this
> >>     
> >
> > PV domains just have videoram = 0.
> >   
> But you abort libxl_set_memory_target if the videoram node is not found. 
> Which won't be for PVs with no videoram...
> +    videoram_s = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, 
> "%s/memory/videoram", dompath));
> +    if (!videoram_s)
> +        return -1;
> 

The videoram node will be found, and the value will be 0.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel