|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool |
From: |
Brendan Cully <brendan@xxxxxxxxx> |
Date: |
Tue, 1 Dec 2009 15:53:50 -0800 |
Cc: |
andy@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx |
Delivery-date: |
Tue, 01 Dec 2009 15:53:31 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<4B15A111.1050004@xxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Mail-followup-to: |
jeremy@xxxxxxxx, pasik@xxxxxx, konrad.wilk@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, andy@xxxxxxxxx |
References: |
<patchbomb.1258074621@xxxxxxxxxxxx> <20091113141859.GB23952@xxxxxxxxxxxxxxxxxxx> <20091113213627.GD11642@xxxxxxxxxxxxxxxxx> <20091201152012.GY16033@xxxxxxxxxxx> <20091201161619.GA2438@xxxxxxxxxxxxxxxxxxxx> <4B15A111.1050004@xxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
On Tuesday, 01 December 2009 at 15:04, Jeremy Fitzhardinge wrote:
> On 12/01/09 08:16, Brendan Cully wrote:
> > I'll probably take a crack at this soon. From a quick look at the
> > pvops suspend code, it seems like it may suffer from a race when
> > multiple suspends are issued that Keir fixed in the 2.6.18 tree some
> > time ago -- it'd be better to get that fixed before porting the event
> > channel patch.
> >
>
> What's the bug? I don't see a reentrancy issue there because the
> suspend happens synchronously in the xenwatch thread under
> xenwatch_mutex. Or race for that matter.
>
> Am I missing something?
I'll need to take a closer look, but the race I'm remembering was fixed
in the 2.6.18 tree here:
http://xenbits.xen.org/linux-2.6.18-xen.hg/rev/49ffe9ef67d4
> Of course, if you start triggering suspends via event channels, we'll
> need to work out something else.
yep.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|