[Xen-devel] Re: [PATCH 01/14]: libxenlight, refactore device destroy code

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 30 Nov 2009, Andres Lagar-Cavilla wrote:
> Refactor libxl device destroy code. Abstract function
> waiting for the watch on the state node to fire.
> Create a generic device delete function.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> 

while I appreciate the general idea, every time you call
wait_for_dev_destroy you reset the timeout to LIBXL_DESTROY_TIMEOUT
while in the current code the timeout for the select is only set once at
the beginning, so that the global wait time it is going to be
LIBXL_DESTROY_TIMEOUT.

Could you please resend the patch adding an additional timeout param to
wait_for_dev_destroy, set to LIBXL_DESTROY_TIMEOUT before the while loop
in libxl_devices_destroy?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel