WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux: force proper address translation in Dell

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux: force proper address translation in Dell RBU
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 19 Nov 2009 12:22:45 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Douglas_Warzecha@xxxxxxxx
Delivery-date: Thu, 19 Nov 2009 09:24:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B0522FB0200007800020C9D@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B0522FB0200007800020C9D@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Nov 19, 2009 at 09:50:35AM +0000, Jan Beulich wrote:
> Replacing virt_to_phys() by virt_to_bus(), and adding code to ensure
> contiguity as required by the firmware.
> 
> As usual, written and tested on 2.6.27.37 and made apply to the 2.6.18
> tree without further testing.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> Tested-by: Douglas Warzecha <Douglas_Warzecha@xxxxxxxx>
> 
> --- sle11-2009-10-16.orig/drivers/firmware/dell_rbu.c 2009-02-02 
> 09:22:26.000000000 +0100
> +++ sle11-2009-10-16/drivers/firmware/dell_rbu.c      2009-10-26 
> 16:34:16.000000000 +0100
> @@ -169,9 +169,28 @@ static int create_packet(void *data, siz
>                       spin_lock(&rbu_data.lock);
>                       goto out_alloc_packet_array;
>               }
> +#ifdef CONFIG_XEN
> +             if (ordernum && xen_create_contiguous_region(
> +                     (unsigned long)packet_data_temp_buf, ordernum, 0)) {
> +                     free_pages((unsigned long)packet_data_temp_buf,
> +                                ordernum);
> +                     printk(KERN_WARNING
> +                             "dell_rbu:%s: failed to adjust new "
> +                             "packet\n", __func__);
> +                     retval = -ENOMEM;
> +                     spin_lock(&rbu_data.lock);
> +                     goto out_alloc_packet_array;
> +             }
> +#endif

I was under the impression we did not want to create any of the #ifdef 
CONFIG_XEN
at all. As a matter of fact, to actually eliminate or minimize the level of 
them.

Is there no other way to do this?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>