 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c
| To: | Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 10 Nov 2009 07:36:49 +0000 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Xiao Guangrong <ericxiao.gr@xxxxxxxxx> |
| Delivery-date: | Mon, 09 Nov 2009 23:37:14 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4AF8DF5D.2090306@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcphtvrRaBZhEa2/QgugXNq1fVK3xAAIZUr/ |
| Thread-topic: | [PATCH] x86 boot: simplify reloc.c |
| User-agent: | Microsoft-Entourage/12.20.0.090605 |
On 10/11/2009 03:34, "Xiao Guangrong" <xiaoguangrong@xxxxxxxxxxxxxx> wrote: > This patch simplify reloc.c with: > 1): no need separate make > reloc.c -> reloc.o -> reloc.lnk -> reloc.bin -> reloc.S, > and static embed reloc.S into head.S > 2): reuse memcpy() in string lib > 3): remove assemble code in the head of reloc.c > > [ It is just a cleanup patch and not change the code's logic, and it work well > on x86. > Not have x86_64 machine in my hand, thanks very much if someone can test it > on x86_64 ] The patch misses the point of reloc.c, which is that it is supposed to run in 32-bit mode. All the stuff you stripped out is exactly what's needed to make it work with 64-bit Xen. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Latest xen/master, Pasi Kärkkäinen |
|---|---|
| Next by Date: | [Xen-devel] Re: [PATCH] e820: fix clip_to_limit(), Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] x86 boot: simplify reloc.c, Xiao Guangrong |
| Next by Thread: | [Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c, Xiao Guangrong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
