WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ignore guest writes to read only memory regions

To: "Li, Xin" <xin.li@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ignore guest writes to read only memory regions or memory holes in EPT
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 26 Oct 2009 09:08:39 +0000
Cc:
Delivery-date: Mon, 26 Oct 2009 02:09:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E88DD564E9DC5446A76B2B47C3BCCA15021EBFD74B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpTshwet9Mx65+CR7O1y3TC0QRywQCZEfqgAAFg/qA=
Thread-topic: [Xen-devel] [PATCH] ignore guest writes to read only memory regions or memory holes in EPT
User-agent: Microsoft-Entourage/12.20.0.090605
On 26/10/2009 08:45, "Li, Xin" <xin.li@xxxxxxxxx> wrote:

>> ignore guest writes to read only memory regions or memory holes in EPT.
> 
> Keir,
> For reads from memory holes, hw returns a value with all bits set. Xen should
> emulate this behavior, and this needs to change Xen x86 instruction emulation
> code. do we already have such logic in Xen?
> 
> In early days, such reads were sent to Qemu, which returns 0xFFFFFFFF, 0xFFFF
> or 0xFF.

I think we should already handle this correctly with the existing
handle_mmio() case in ept_handle_violation(). The read should indeed go to
qemu which should do the right thing.

But also see my previous email about simplifying and robustifying
ept_handle_violation().

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel