WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 08/13] Xen paravirtualised PCI hotplug.

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 08/13] Xen paravirtualised PCI hotplug.
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Fri, 16 Oct 2009 11:59:55 +0100
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Delivery-date: Fri, 16 Oct 2009 03:59:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1255468952-27052-9-git-send-email-konrad.wilk@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1255468952-27052-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-2-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-3-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-4-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-5-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-6-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-7-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-8-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-9-git-send-email-konrad.wilk@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.23 (X11/20091001)
Konrad Rzeszutek Wilk wrote:
The pciback driver adds two new states that are shared by the pcifront
and pciback. This is a patch pulled from the linux-2.6-xen-sparse tree.

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
 include/xen/interface/io/xenbus.h |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/include/xen/interface/io/xenbus.h 
b/include/xen/interface/io/xenbus.h
index 46508c7..9fda532 100644
--- a/include/xen/interface/io/xenbus.h
+++ b/include/xen/interface/io/xenbus.h
@@ -27,8 +27,14 @@ enum xenbus_state
        XenbusStateClosing      = 5,  /* The device is being closed
                                         due to an error or an unplug
                                         event. */
-       XenbusStateClosed       = 6
+       XenbusStateClosed       = 6,
+ /*
+       * Reconfiguring: The device is being reconfigured.
+       */
+       XenbusStateReconfiguring = 7,
+
+       XenbusStateReconfigured  = 8
 };
ouch.

what's the usefulness of those 2 new states here ?
the xenbus state is just here to represent the connection status of the xenbus device, doesn't reconfiguring/reconfigured state is something about the underlying device more than the xenbus device ?

And regarding the xenbus-state state machine, what happen when you reach 8 ?
does every userspace handler need to handle it as a 4 ? if yes why is it not 4 ?

--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>