| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 4/5] x86/fixmap: add a predicate for usermode fix
|
To: |
"Jeremy Fitzhardinge" <jeremy.fitzhardinge@xxxxxxxxxx>, "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 4/5] x86/fixmap: add a predicate for usermode fixmaps |
|
From: |
"Jan Beulich" <JBeulich@xxxxxxxxxx> |
|
Date: |
Tue, 06 Oct 2009 11:23:54 +0100 |
|
Cc: |
Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Zach Brown <zach.brown@xxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx> |
|
Delivery-date: |
Tue, 06 Oct 2009 03:24:23 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1254790211-15416-5-git-send-email-jeremy.fitzhardinge@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1254790211-15416-1-git-send-email-jeremy.fitzhardinge@xxxxxxxxxx> <1254790211-15416-5-git-send-email-jeremy.fitzhardinge@xxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx> 06.10.09 02:50 >>>
>--- a/arch/x86/include/asm/fixmap.h
>+++ b/arch/x86/include/asm/fixmap.h
>@@ -181,6 +181,24 @@ static inline void __set_fixmap(enum fixed_addresses idx,
>
> extern void __this_fixmap_does_not_exist(void);
>
>+static inline bool user_fixmap(enum fixed_addresses fixmap)
>+{
>+ switch (fixmap) {
>+#ifdef CONFIG_X86_32
>+ case FIX_HOLE ... FIX_VDSO:
>+#else
>+ case VSYSCALL_LAST_PAGE ... VSYSCALL_HPET:
>+#ifdef CONFIG_PARAVIRT_CLOCK_VSYSCALL
>+ case FIX_PVCLOCK_TIME_INFO:
>+#endif
>+#endif
>+ return true;
>+
>+ default:
Isn't that nested #ifdef rather meant to be successive to the 32-/64-bit
one?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home